Color Picker looks bad after recent improvements
tracked
AlettaMondragon Resident
Following the recent improvements of the Color Picker that adds 32 extra color save slots, these color boxes are now vertical rectangles instead of the original horizontal rectangles. The increased overall size of these boxes is a good thing, but the palette looks really bad like this. It would be much better if the color save slots were squares, so they would be still bigger than before, but they would look nice, and that way the floater wouldn't have to be so big either.
It looks like the problem, which can be seen at https://github.com/secondlife/viewer/commit/fe425958e42360f2258fdde596e062471ecde29b is that the color palette is generated by overall parameters instead of stacking the color boxes. As seen in llfloatercolorpicker.cpp line 100/102, mPaletteRegionHeight was changed from 40 to 120. This didn't make the color boxes 3 times taller than before because the 2 rows were changed to 4 as well, but the 120 overall height is definitely too much, resulting in vertical rectangle boxes.
Reducing mPaletteRegionHeight to 100 would probably result in much better looking, square or almost square-shaped boxes instead of what we can see now.
First screenshot is the old layout with the horizontal rectangle color boxes (from Firestorm 7.2.5), second screenshot is the current layout with the weird vertical rectangle color boxes on SLV 26.4.0. I don't think we need small, horizontal rectangle boxes here, but squares or near squares would be much better than this.
Photo Viewer
View photos in a modal
Log In

Dan Linden
updated the status to
tracked

Dan Linden
Thank you for the feedback, AlettaMondragon!
This is tracked at https://github.com/secondlife/viewer/issues/6685
AlettaMondragon Resident
Lettie Linden Can you delete one of these two that are merged right now? They are identical, Canny had a hiccup when I edited it and duplicated it as it seems.

Lettie Linden
Merged in a post:
Color Picker looks bad after recent improvements
AlettaMondragon Resident
Following the recent improvements of the Color Picker that adds 32 extra color save slots, these color boxes are now vertical rectangles instead of the original horizontal rectangles. The increased overall size of these boxes is a good thing, but the palette looks really bad like this. It would be much better if the color save slots were squares, so they would be still bigger than before, but they would look nice, and that way the floater wouldn't have to be so big either.
It looks like the problem, which can be seen at https://github.com/secondlife/viewer/commit/fe425958e42360f2258fdde596e062471ecde29b is that the color palette is generated by overall parameters instead of stacking the color boxes. As seen in llfloatercolorpicker.cpp line 100/102, mPaletteRegionHeight was changed from 40 to 120. This didn't make the color boxes 3 times taller than before because the 2 rows were changed to 4 as well, but the 120 overall height is definitely too much, resulting in vertical rectangle boxes.
Reducing mPaletteRegionHeight to 100 would probably result in much better looking, square or almost square-shaped boxes instead of what we can see now.
First screenshot is the old layout with the horizontal rectangle color boxes (from Firestorm 7.2.5), second screenshot is the current layout with the weird vertical rectangle color boxes on SLV 26.4.0. I don't think we need small, horizontal rectangle boxes here, but squares or near squares would be much better than this.
Photo Viewer
View photos in a modal