Remove code making cryptic and frequent messages in viewer logs
tracked
LagFest Resident
Get some group notices (IM_GROUP_NOTICE & IM_GROUP_REQUESTED) and it may run the code like this in newview/llimprocessing.cpp:
// Note There is more elements in 'tokens' ...
for (int i = 0; i < 6; i++)
{
LL_WARNS() << *(iter++) << LL_ENDL;
iter++;
}
This can create multiple lines in the logs like:
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : c9a95e49-09c6-462b-97b2-7b8fdcf4a006
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : c9a95e49-09c6-462b-97b2-7b8fdcf4a006
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : 8a000
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : 0
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : 8a000
2024-11-06T19:57:13Z WARNING # newview/llimprocessing.cpp(1127) LLIMProcessing::processNewMessage : (No Description)
Which sounds scary but isn't. It's also cryptic, and the way the iterator increments, there is no check if it runs off the end of the container.
Log In
Atlas Linden
tracked
Thanks for the report, LagFest!
This is now tracked here: https://github.com/secondlife/viewer/issues/3052